Skip to content

chore: replace Batteries.HashMap with a shim around Std.HashMap #1063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Mar 30, 2025
Merged

chore: replace Batteries.HashMap with a shim around Std.HashMap #1063

merged 10 commits into from
Mar 30, 2025

Conversation

kim-em
Copy link
Collaborator

@kim-em kim-em commented Nov 24, 2024

No description provided.

@github-actions github-actions bot added the WIP work in progress label Nov 24, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Nov 24, 2024
@leanprover-community-mathlib4-bot
Update Batteries branch for testing leanprover-community/batteries#1063
15046cf
@kim-em kim-em marked this pull request as ready for review November 24, 2024 03:09
@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented Nov 24, 2024 •
edited
Loading

Mathlib CI status (docs):

leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Nov 24, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover-community/batteries#1063
4285834
digama0
digama0 reviewed Nov 24, 2024
View reviewed changes
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Nov 25, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover-community/batteries#1063
06f078f
TwoFX
TwoFX reviewed Nov 25, 2024
View reviewed changes
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Nov 25, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover-community/batteries#1063
7a447d0
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict This PR has merge conflicts with the `main` branch which must be resolved by the author. label Dec 2, 2024
@kim-em kim-em removed WIP work in progress merge-conflict This PR has merge conflicts with the `main` branch which must be resolved by the author. labels Dec 3, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Dec 3, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover-community/batteries#1063
eec010f
@fgdorais fgdorais added the awaiting-review This PR is ready for review; the author thinks it is ready to be merged. label Dec 6, 2024
@fgdorais fgdorais requested a review from digama0 December 12, 2024 13:20
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict This PR has merge conflicts with the `main` branch which must be resolved by the author. label Jan 4, 2025
@kim-em
Copy link
Collaborator Author

kim-em commented Jan 8, 2025

We've decided to wait on this until some further verification lemmas have been written for Std.HashMap. These are now being actively worked on, so hopefully it won't be too long.

@fgdorais fgdorais added depends on core changes This PR need only be reviewed after changes land in Lean core. and removed awaiting-review This PR is ready for review; the author thinks it is ready to be merged. labels Jan 18, 2025
@kim-em kim-em removed the depends on core changes This PR need only be reviewed after changes land in Lean core. label Mar 24, 2025
@kim-em kim-em added awaiting-review This PR is ready for review; the author thinks it is ready to be merged. and removed merge-conflict This PR has merge conflicts with the `main` branch which must be resolved by the author. labels Mar 24, 2025
@kim-em
Copy link
Collaborator Author

kim-em commented Mar 24, 2025

Those additional verification lemmas about HashMap.toList and HashMap.fold have now landed, so as far as I'm aware we have feature parity with downstream libraries based on the old HashMap, and I would like to proceed.

leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Mar 24, 2025
@leanprover-community-mathlib4-bot
Trigger CI for leanprover-community/batteries#1063
aa4e0f0
@kim-em kim-em added this pull request to the merge queue Mar 30, 2025
Merged via the queue into main with commit 7ad3747 Mar 30, 2025
2 checks passed
@github-actions github-actions bot removed the awaiting-review This PR is ready for review; the author thinks it is ready to be merged. label Mar 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TwoFX TwoFX TwoFX left review comments

@digama0 digama0 Awaiting requested review from digama0

Assignees
No one assigned
Labels
builds-mathlib
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kim-em @leanprover-community-bot @digama0 @TwoFX @fgdorais @leanprover-community-mathlib4-bot